"Lcawte" changed the status of pywikipedia.r9800 to "resolved" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9800#c27388
Old Status: fixme > New Status: resolved Commit summary for pywikipedia.r9800: don't change file namespaces at pt-wiki due to bug #3346901 (new feature should be implemented) Lcawte's comment: <pre> [16:24:48] <harriv> cosmetic_changes.py has missing ":" in current SVN head [16:25:21] <Lcawte> Really, line number? [16:25:59] <harriv> 327 [16:26:34] <harriv> - if nsNumber == 6 and family.name == 'wikipedia' [16:26:35] <harriv> + if nsNumber == 6 and family.name == 'wikipedia': [16:26:58] <Lcawte> Any visible problems caused by it? [16:27:34] <harriv> I noticed it when doing interwiki.py with cosmetic changes enabled [16:28:18] <Lcawte> Any error messages? [16:28:30] <harriv> syntax error [16:29:01] <Lcawte> Ok, cheers, I'll commit that back in a second (just got to check some stuff) [16:30:24] <Lcawte> When was this, I've spotted a change to that line recently [16:30:24] <harriv> http://pastebin.com/MSNL0UMW here's traceback [16:30:37] <harriv> about 10 minutes ago :) [16:30:58] <Lcawte> Running latest svn update right? [16:31:07] <harriv> yes [16:31:26] <Lcawte> http://svn.wikimedia.org/viewvc/pywikipedia/trunk/pywikipedia/cosmetic_changes.py?r1=9800&r2=9766 is one thing I've spotted [16:32:13] <harriv> bad xqt :) [16:32:26] <Lcawte> Yeah, I definately think its that change... I ran cosmetic_changes at teh weekend, now it won't even start [16:33:22] <Lcawte> ok, I'll commit that and bug him about it </pre> The change to line 327 broke the script, r9801 adds a quickfix from a user (un-reviewed) that fixes the script. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
