"Catrope" changed the status of MediaWiki.r105627 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105627#c27414
Old Status: deferred > New Status: ok Commit summary for MediaWiki.r105627: Remove the last of the hard-coded english from AFTv5 feedback page. I'm assuming that the actual form values don't need localization, despite being english, since they aren't user-facing. Also, I went ahead and escaped a bunch of output, because better safe than sorry I guess. Catrope's comment: This change is OK, but this special page still needs serious work. The JS needs to use ResourceLoader and the HTML would be better off being built with the Xml/Html functions. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
