"Catrope" changed the status of MediaWiki.r105688 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105688
Old status: new
> New status: ok
Commit summary for MediaWiki.r105688:
Moved tooltip out of the titlebar so that it can be closed from the dialog:
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js:
- Replaced template helpToolTip with helpToolTipTrigger
- Moved the tooltip itself into template panelOuter: the ui div
now
contains ui-inner and the tooltip
- Updated loadForm() to put the form in ui-inner, separate the
tooltip
setup from the tooltip trigger setup, and replace the
standard link for
Learn More with a click event to get around the dialog bug
preventing that
link from working as expected
- Removed the tooltip events from openAsModal()
- Updated openAsModal() and closeAsModal() to make sure the
tooltip
gets hidden when switching between modes
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css:
- The tooltip and its trigger now have separate wrap classes
- Updated positioning to put the tooltip back where it belongs
visually, even though it's in a totally different place in
the markup
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
