"Catrope" changed the status of MediaWiki.r105744 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105744
Old status: new
> New status: ok
Commit summary for MediaWiki.r105744:
Updates for the jquery module, mostly related to CTAs:
- Made the confirmation message act as the title for CTAs
- Tooltips now work when you're in a CTA
- Structural changes to make it easier for me to load the CTA or the
form
as needed (controlled manually on the console for now; later versions
will
have a url override):
- New properties toDisplay and hasContainers
- New edit CTA template titleConfirm
- Updated edit CTA's getTitle() to build and localize the
confirmation
message before sending it back as an html string
- Renamed loadForm() to showForm()
- Moved building of containers into its own method
loadContainers()
- Updated showCTA() to set a custom class on its ui block,
change the title
in both places, and reset the dialog dimensions
- Replaced calls to loadForm() with calls to load()
- Moved clearing of the containers out of clear() and into a
new method
clearContainers() so that load() can use it too
- Updated markShowstopperError() to indicate that the tool is
now showing
an error
- Moved setting the dialog dimensions out of openAsModal() into
its own
method setDialogDimensions() so that showCTA() can use it too
- Removed currentDefaultText from the $ scope and put it in the bucket
2
properties where it belongs
- Dropped unused code for positioning the dialog
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
