"Catrope" changed the status of MediaWiki.r105750 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105750#c27421
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r105750:
Updated the jquery module to override the edit CTA if the article is not
editable:
- New method verify() for ctas[1]
* NB: Contents copied from ATFv4
- New method selectCTA() checks that the requested CTA actually exists,
and
runs its verify method (if it has one) to check that it can be
allowed.
Failure at either point causes the empty CTA to be selected.
- Updated submitForm() to use selectCTA() rather than setting it
directly
Catrope's comment:
<pre>
+ temp = $.articleFeedbackv5.ctas[requested];
</pre>
This variable is leaked to the global scope. OK otherwise.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
