"Catrope" changed the status of MediaWiki.r105898 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105898
Old status: new
> New status: ok
Commit summary for MediaWiki.r105898:
Added Learn More CTA:
- ArticleFeedbackv5.i18n.php:
- Changed 'articlefeedbackv5-cta1-thanks' to
'articlefeedbackv5-cta-thanks'
- Changed 'articlefeedbackv5-cta1-confirmation-followup' to
'articlefeedbackv5-cta-confirmation-followup'
- Added 'articlefeedbackv5-cta2-confirmation-title',
'articlefeedbackv5-cta2-confirmation-call', and
'articlefeedbackv5-cta2-button-text'
- Added CTA messages to documentation
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css:
- Changed class name of edit-cta-link to cta-button
- Updated specialized positioning for cta titles so that it
applies to
CTAs 0 and 2 as well
- Adjusted position of button for CTA 2
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js:
- Added "Learn More" CTA as #2
- Renamed class articleFeedbackv5-edit-cta-link to
articleFeedbackv5-cta-button
- Renamed classes and messages for the confirmation message so
that
they're not just CTA 1 only
- Updated selectCTA() to choose CTA 2 if CTA 1 was requested but
invalid
- ArticleFeedbackv5.hooks.php
- Updated messages sent to modules
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview