"Catrope" changed the status of MediaWiki.r105928 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105928#c27424
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r105928:
AFTv5: changed bucketing odds to 1/3 for option 1,2,3. changed loading
mechanism for a) efficiency and b) remove lottery
Catrope's comment:
Please use tabs instead of spaces. The easiest test is to change your tab size
setting and see if things look broken. For instance, the diff on this page uses
a tab size of eight, and as you can see the indentation is pretty messed up.
<pre>
+ for( cat in categories['current'] ) {
</pre>
You need to use <code>var cat</code> here, otherwise the <code>cat</code>
variable is leaked to the global scope.
OK otherwise. Marking fixme for the variable leakage.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
