"Mdale" posted a comment on MediaWiki.r104400. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104400#c27427
Commit summary for MediaWiki.r104400: updates per code review comments: http://www.mediawiki.org/wiki/TimedMediaHandler/ReviewNotes#mw.TextSource.js == mw.TimedText.js == * fixed spelling: userLanugage to userLanguage * added default bottom padding config for textOffset * added code comment to clarify Animate param in text resize during player resize * added comment to explain default relative text size * corrected spelling of loadCurrentSubSrouce to loadCurrentSubSource and added function documentation * Removed all the add transcript support. Should be part of a gadget ( i.e once this ships could restore the miro universal subs gadget to a working state ) * added code documentation for track "kind" attribute and associated menu build out * moved TimedText.BelowVideoBlackBoxHeight to config == mw.TextSource.js == ( Moved TextSource to its own file ) * move loaded = true to after actual loading. * updated comments to point to bug 29126 * Added some comments for large regex used in srt parsing. * refactored the match handling of srt parsing to local convenience functions == mw.TimedTextMediaWikiSources.js == * fixed spelling ofmw.MediaWikTrackProvider * clean up getTimedTextNS conditional logic * updated default value to 710 per http://www.mediawiki.org/wiki/Extension_namespace_registration namespace register Mdale's comment: * nope .. not meant to be commented out ( follow up in r105932 ) * No this is not an XSS because we only load caption text that has been put through the mediawiki render. But in principal it would be good to scrub that html. ( do we have a utility to do that yet? ) Added a note. * originally the mapping was non-linear .. but now its linear i guess so I will just use a function call. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
