"NeilK" posted a comment on MediaWiki.r106059.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106059#c27531

Commit summary for MediaWiki.r106059:

reverting r105766, does not work, also too hacky

NeilK's comment:

Maybe instead of using blind offsets, you could use a regex. That would be less 
likely to fail.

Or, refactor it so that the other methods are returning a list of wikiText 
arguments, and then construct the template string at the last minute. That 
might be too much work though.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to