"Awjrichards" changed the status of Wikimedia.r492 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/492#c27581
Old Status: new
> New Status: fixme
Commit summary for Wikimedia.r492:
Many changes in this check in. Implemented Paypal adapter and testing.
Activated Stomp tests. Able to send and remove messages to ActiveMQ. At 84%
code coverage. New setters and getters added still need unit testing. Added
several unit tests.
Awjrichards's comment:
In Listener/Adapter/Abstract.php:
<pre>
public function openOutputHandle( $logFile = '' )
{
if ( empty( $logFile ) ) {
// Create a default log file name
$this->setLogFile();
$logFile = $this->getLogFile();
}
$this->outputHandle = fopen( $logFile, 'a' );
}
</pre>
If you do $adapter->openOutputHandle( 'some log file' );, the file that gets
passed to fopen() bypasses some of the safety checks that happen in
setLogFile() and ignores the log file that was defined in the constructor!
I'm still reviewing the codebase, so likely more comments to follow.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
