"Aaron Schulz" posted a comment on MediaWiki.r105764. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105764#c27585
Commit summary for MediaWiki.r105764: * Added revision's timestamp to OutputPage along with revision ID; avoid a DB hit in Skin::lastModified() when showing parser cache's content. This changed with the removal of $wgArticle in Skin since now it's a different WikiPage object and thus WikiPage::setTimetstamp() call is useless (but still kept). * Added ParserOutput::(get|set)Timestamp() and the $mTimestamp member; avoid messing with isset() Aaron Schulz's comment: So Skin and OutputPage have different Page instances? Isn't that a performance regression. It's ok to allow it, but it shouldn't happen on actual page views in practice. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
