"Catrope" changed the status of MediaWiki.r105965 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105965#c27631
Old Status: new > New Status: ok Commit summary for MediaWiki.r105965: making sure nothing touches the public reporting table except the cron job, removing YearlyTotal since its redundant with ContributionTotal Catrope's comment: <pre> - array( 'received > ' . strtotime( 'July 1st 2008' ) ), + array( 'received > ' . strtotime( 'July 1st 2011' ) ), </pre> Maybe you should avoid hardcoding years in the code like that? ;) <pre> + "prd_date = '$today'", </pre> Please use <code>'prd_date' => $today</code> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
