"Catrope" changed the status of MediaWiki.r106251 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106251
Old status: new
> New status: ok
Commit summary for MediaWiki.r106251:
First pass addressing bug #32992:
- modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js:
- Moved determination of whether to track clicks out into the
jquery
plugin
- Updated clickFeedbackLink() to use the jquery plugin for
tracking
- Prefixing of tracking ids now happens in the plugin
- The vertical link now has its own tracking id
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js:
- New property clickTracking
- New methods checkClickTracking(), bucketName(), ctaName(),
trackingUrl(), editUrl(), and trackClick()
- Updated init() to call checkClickTracking()
- Updated bucket 4 and cta 1 to use editUrl()
- Added trackClick() to the externally-accessible methods
- Added click tracking for:
- Submit button (buckets 1, 2, and 3)
- Edit button for bucket 4
- Edit button for cta 1
- Learn more button for cta 2
- Form load
- CTA load
- Overlay close
- ArticleFeedbackv5.php:
- Switched to tracking everybody by default
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
