"Khorn (WMF)" posted a comment on MediaWiki.r106109. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106109#c27685
Commit summary for MediaWiki.r106109: Data handling cleanup in DonationInterface, part 2 of [some]. ALL FORM CLASSES: Removed the $form_data array. All data will now be fetched directly from the gateway adapter object via Gateway_Form::getEscapedValue(). Started work removing what will hopefully work out to be all instances of child form classes touching $wgRequest or $wgOut directly: These will either be functionalized and moved to Gateway_Form, added to the data population and normalization routines in DonationData, or removed entirely. Khorn (WMF)'s comment: ...and TwoStepAmount should be either moved somewhere that says "I'm not real" or deleted soon, so people stop mistaking it for a potential production form. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
