"Edokter" posted a comment on MediaWiki.r105280.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105280#c27751

Commit summary for MediaWiki.r105280:

Diff colors now use the french Wikipedia scheme

The french community has been using a specific set of colors for diff, it is
believed to be easier to read for people perceiving colors differently.

Source is from:
http://fr.wikipedia.org/w/index.php?oldid=72567845&uselang=en

This commit override r94429 / r94461.

See also docs/uidesign/mediawiki.action.history.diff.html

Edokter's comment:

Really, personally I don't care which color is left/right. My patch just swaps 
them (and resoted the gray context background).

While we're at at, let's finish the job properly and get it ready for 1.19. I 
made some further tweaks that makes white-space:pre-wrap apply to the entire 
diff cell instead of only the .diffchange part. This will show off indents 
quite nicely. I have a patch ready (so hold on before applying bug 33139).

Second, bug 25697 has been open for a year and a half, waiting for a patch 
review that will fix the empty context row issue (that collapses an entire row 
if no cell has content). If we can please have that fixed, then I would 
consider diffs to be truly "done". 

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to