"NeilK" posted a comment on MediaWiki.r104687. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104687#c27789
Commit summary for MediaWiki.r104687: Use database to track uploaded chunks and concatenate at the end. with i18n documentation dont break phpunit follow up r93720 NeilK's comment: Doesn't this have the same flaw as some of the other implementations of uploadChunks -- we rely on chunks being sent to us in order? It seems to me that if the uploader uploads the final chunk, whose offset + size matches the declared size of the file, then we initiate a concatenate. i.e. if, for some reason, we received these messages: Client: this file is going to be 3MB long Client: here's a chunk, with offset 0MB and it is 1MB long Server: right, I'll call that chunk 1 Client: here's a chunk, with offset 2MB and it is 1MB long Server: right, I'll call that chunk 2. Oh look, we reached 3MB, so we are finished. I'll concatenate all these together. I think Tim rejected the other implementation because it assumed we could simply concat chunks together. While we are no longer using filesystem append this seems to have the same issue? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
