"Khorn (WMF)" changed the status of Wikimedia.r940 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/940#c27787
Old Status: new > New Status: fixme Commit summary for Wikimedia.r940: Added limbo module to queue2civicrm. Khorn (WMF)'s comment: One thing: We ran into a problem in the future (from the perspective of this revision, anyway) where checking the stomp message's date field with is_integer was resulting in an explosion if it was an integer string, whereas is_numeric in the same position did what we'd have expected out of is_integer. See r949 for clarification on what probably sounds like complete madness. My point is: We should probably do that here as well. (fixme'd just so we can all find this easily) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
