"Aaron Schulz" posted a comment on MediaWiki.r106280. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106280#c27805
Commit summary for MediaWiki.r106280: * Made FileBackendMultiWrite substitute the backend name portion of storage paths as needed since each backend has it's own name (registration disallowes duplicate names). * Refactored doOperations() code duplication into a FileBackendBase::attemptOperations() function. Removed code that reset $predicates from FileBackendMultiWrite as the paths include the backend name already, so there is no ambiguity. * Made FileBackend::doOperations() use shared locks where possible (some lock managers may interpret LOCK_UW as LOCK_EX instead of LOCK_SH) * Removed getFileHash() comment (function removed). * Renamed FSFile::sha1Base36() -> FSFile::getSha1Base36() Aaron Schulz's comment: Actually, FileBackendMultiWrite constructs the sub-backends itself to hide them from registration, so we don't care about that. It's still useful to give them their own names though, as the constructor allows. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
