"Aaron Schulz" changed the status of MediaWiki.r105764 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105764#c27880
Old Status: new > New Status: fixme Commit summary for MediaWiki.r105764: * Added revision's timestamp to OutputPage along with revision ID; avoid a DB hit in Skin::lastModified() when showing parser cache's content. This changed with the removal of $wgArticle in Skin since now it's a different WikiPage object and thus WikiPage::setTimetstamp() call is useless (but still kept). * Added ParserOutput::(get|set)Timestamp() and the $mTimestamp member; avoid messing with isset() Aaron Schulz's comment: <pre>+$this->mPage->setTimestamp( $this->mParserOutput->getTimestamp() );</pre> Are you sure that you will never be setting it to null (and thus causing an extra query)? ParserOutput->getTimestamp() isn't assured to return a timestamp. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
