"Aaron Schulz" changed the status of MediaWiki.r102187 to "resolved" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102187#c27896
Old Status: new > New Status: resolved Commit summary for MediaWiki.r102187: * Merged Title::userCanRead() check in Title::getUserPermissionsErrors() * (bug 26020) Setting $wgEmailConfirmToEdit to true no longer removes diffs from recent changes feeds * Added second parameter to Title::userCan() and Title::quickUserCan() to allow callers to pass the User object to use for checks; this changes Title::userCan()'s second parameter from "do expensive queries" flag to User, but all callers should have been updated in r102183 * Updated callers that might throw a PermissionsError to use getUserPermissionsErrors() instead and pass the error array to the exception * Refactored duplicate code in missingPermissionError() * Moved Title::isNamespaceProtected() a bit upper and Title::userCanRead() near Title::userCan() to have related functions in the same location * Some minor refactoring in permission-related functions in Title Aaron Schulz's comment: <pre>+ # Only to these checks is there's something to check against</pre> Typo. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
