"MaxSem" posted a comment on MediaWiki.r106507. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106507#c27906
Commit summary for MediaWiki.r106507: Fixes to address MaxSem's comment on r106480 regarding DB2 tables.sql syntax, indentation, and capitalization: * Made all table and column names lowercase for consistency * Removed " from around some "identifiers". Not necessary for DB2. * Applied consistent indentation to all table declarations * Applied consistent indentation to all index declarations * Moved all PRIMARY KEY clauses to their own line for consistency and max line length * Moved all ON clauses to their own line for consistency and max line length * Fixed vertical alignment for column names and data types, remove all other vertical alignment * Removed commented out references to SEQUENCE values, as they are used in neither DB2 nor MySQL schemas. * Consistent spacing around parens () and commas , * Capitalized all data types. * Note: tables.sql is approaching DB2's 32k limit. It will need to be split into two files soon. MaxSem's comment: Thanks:) Note that the 32K limit is irrelevant here because sourceFile() feeds the SQL statement-by-statement instead of whole file at once. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
