"Catrope" changed the status of MediaWiki.r106514 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106514#c27936
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r106514:
Expose rev_sha1/ar_sha1 to API (bug 21860)
Catrope's comment:
<pre>
+ $rev['sha1'] = $row->ar_sha1;
</pre>
This outputs the SHA1 hash in base 36, matching your parameter documentation.
However, imageinfo outputs it in hex:
<pre>
$vals['sha1'] = wfBaseConvert( $file->getSha1(), 36,
16, 40 );
</pre>
For consistency, we should use hex everywhere.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
