"IAlex" changed the status of MediaWiki.r106546 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106546#c27940
Old Status: new > New Status: fixme Commit summary for MediaWiki.r106546: Bug 30047 - Language selection does not change the Content-language Patch from Author: Harald Stowasser IAlex's comment: I don't see what this has to do in the LanguageSelector extension, since this extension is meant to allow anonymous users to select their interface language (or even have it directly set from the Accept-Language header), but not to alter the Title object, this is more for [[Extension:Polyglot]] or similar. Some other notes: * <code>$wgLanguageSelectorRequestedLanguage</code> doesn't exist anymore * <code>$wgLanguageSelectorAdjustContent</code> is not defined when including the file (in other words this is a register_globals vulnerability) and it would be better to be a boolean * Altering those members variables of the Title object is really not a good since other member variable may depend on the page title (restrictions, etc.); it would much better to create a new Title object; also altering it in the BeforeInitialize hook is too late, if file cache is enabled, it will be loaded based on the older title from <code>MediaWiki::main()</code>. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
