"Nikerabbit" changed the status of MediaWiki.r106582 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106582#c27962
Old Status: new > New Status: ok Commit summary for MediaWiki.r106582: * Use local context to get messages * Use Language::userTimeAndDate(), Language::userTime() and Language::userDate() instead of Language::timeAndDate(), Language::time(), Language::date() to not depend on $wgUser * Replaced empty() check by check against explicit values Nikerabbit's comment: How about: <pre> -if ( $code === null || $code === '' ) { +if ( strval( $code ) === '' ) { </pre> _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview