"Tim Starling" posted a comment on MediaWiki.r106104. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106104#c27973
Commit summary for MediaWiki.r106104: In DBLockManger: * Added 'dbServers' config option and made the manager skip LB and use the DB factory() function. This assures that the lock queries are in their own session and don't break (or get broken by) other transactions, especially wrt begin/commit/rollback. * Merged 'webTimeout' and 'cliTimeout' into one 'lockExpiry' setting. No need to encourage high values for CLI scripts, as they should be batched anyway. * Removed 'safeDelay' as a config option (determined by other settings now). * Only set $this->statusCache when it might be useful. * Tweaked lock table names (file_locks => filelocks), removed DEFAULT CHARSET (everthing is binary), and set CHECKSUM=0 since it's not useful. * More documentation cleanups and fixes to outdated comments. In MySqlLockManager: * Simplified SET SESSION code and reduced queries. * Made EX locks non-blocking (EX-EX was blocking before). Tim Starling's comment: It would be nice to have the option to be able to use the main DB configuration and not have to configure DBLockManager separately. SqlBagOStuff::getDB() creates DB connections for a very similar reason to this class, and it allows either separate or shared configuration. You could use similar code. If it didn't require any configuration, then we could think about using it by default. A lot of shared hosts use NFS fairly extensively, so a lot of small MediaWiki installations probably have non-functional file locking. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
