"Catrope" changed the status of MediaWiki.r106469 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106469
Old status: new
> New status: resolved
Commit summary for MediaWiki.r106469:
Added edit tracking and tweaked tracking ids for bug #32992:
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js:
- Renamed tracking ids:
- {option}-button-click-{location} to
{option}-button_click-{location}
- {option}-{cta}-button-click-{location} to
{option}-{cta}-button_click-{location}
- All CTA names from cta-{name} to cta_{name}
- Learn more CTA name from learnmore to learn_more
- {option}-overlay-impression to
{option}-impression-overlay
- {option}-overlay-close to {option}-close-overlay
- Updated editUrl() to send articleFeedbackv5_click_tracking,
and if
it's on, to also send articleFeedbackv5_bucket_id,
articleFeedbackv5_cta_id, articleFeedbackv5_link_id, and
articleFeedbackv5_ct_token
* NB: Although nothing else is being done with these
parameters at
this time, future versions may use them outside of
click tracking.
- ArticleFeedbackv5.hooks.php:
- Updated pushTrackingFieldsToEdit() to send
articleFeedbackv5_click_tracking, articleFeedbackv5_bucket_id,
articleFeedbackv5_cta_id, articleFeedbackv5_link_id, and
articleFeedbackv5_ct_token
- Made trackEdit() private and updated it to call out to click
tracking, if articleFeedbackv5_click_tracking is on
- Added trackEditAttempt() and trackEditSuccess()
- ArticleFeedbackv5.php:
- Changed ArticleSaveComplete hook to trackEditSuccess
- Added EditPage::attemptSave hook to trackEditAttempt
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
