"MarkAHershberger" changed the status of MediaWiki.r106499 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106499
Old status: new > New status: ok Commit summary for MediaWiki.r106499: Some fixes for minor issues: * $wgLilyPond needs to default to something (even if we expect user to set it) * Make $wgScoreTrim default to $wgUseImageMagick (seemed like a good idea. I didn't like the check to error out if $wgUseImageMacgick was false, because someone could have image magick installed, but not want to use it for image rendering) * Returning false from ParserFirstCallInit is a _really_ bad idea (it will stop all other extensions from loading, and its kind of non-transparent to end user why the extension just didn't load). Switch the checks in there to be in the main rendering code. (also, checking if $wgLilyPond is executable every time parser is loaded even if not parsing a <score> tag, seemed unnessary) * For messages: Since this is a parser hook, its stored in parser cache, so must use the Wikis content language, not the user language (or next person will get errors in wrong language) *Some of the messages should use parameters (This is especially important for the Page: 1 message, since message may need plural process and digit conversion in some langs) *Wrap Most of the error messages in <Span class="error">. This is what many things put error messages in, and makes it red. (I didn't do that for the comile-error message, perhaps it should also do that, at least for the intro part) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
