"NeilK" posted a comment on MediaWiki.r106663.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106663#c28002
Commit summary for MediaWiki.r106663:
Fix r106636, r106653: revert {{SITENAME}} changes, can't use {{SITENAME}} in JS
messages
NeilK's comment:
Catrope: Yeah, to keep the library 100% testable, I made it so you have to pass
in a hash of magic keywords as a constructor argument. See r106228 where I just
copy over the existing objects with more 'magical' versions
But this is at odds with the library just being there and ready for people to
use, which is what I think people expect. Maybe in initialization we need to
add common magic from wg constants.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
