"Dantman" posted a comment on MediaWiki.r99369. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99369#c28032
Commit summary for MediaWiki.r99369: Fix up makeLinkItem and makeLink: - Don't explicitly name attributes to use (fixes bug on language_links in 1.18) - Allow makeLink to accept options specifying how to wrap links and text Dantman's comment: These options are for very skin-dependent markup design decisions (mostly hacks). For example making a list of links styled as a vertical menu of padding heavy buttons with a left area that acts as a coloured tab on the button by adding an extra span and applying some padding and two different background colours. So no, I don't think the general linker should support this extra stuff. This is really here so that skins using the link builder for complex lists like we use in SkinTemplate don't have to resort to re-adding piles of complex markup to their skins just so that they can add an extra span inside every link in the list so their whole design will actually work. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
