"Bawolff" changed the status of MediaWiki.r100548 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100548#c28033
Old Status: new > New Status: ok Commit summary for MediaWiki.r100548: Add check to see if the user has permission to view the log. Right now the page title and description are still set. Bawolff's comment: Personally I think from a usability perspective, an error would be nicer. For example, suppose there was a misconfiguration, and a log gets restricted that shouldn't. If we just redirect them to public log, the steps a user goes through would look like: *User types in log name, gets all public logs. *User assumes they made a typo or something. *User can't figure out what they did wrong, gets frustrated, etc vs *User types in log name *User gets "This action is restricted to so and so" *User bugs admin, admin fixes issue, everyone happy. However, I suppose that's not directly applicable to this specific commit, and I do agree that the behaviour of this commit is a significant improvement over the previous behaviour of saying here is <log> and then showing all public logs instead. Thus marking ok but with tag todo _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
