"Aaron Schulz" changed the status of MediaWiki.r106760 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106760
Old status: new > New status: ok Commit summary for MediaWiki.r106760: If you request LogEventList to display the combination of 2 log types, and one of those logs are restricted, will generate a warning, since it removes first entry of array, but doesn't re-index the array, and subsequent code makes assumptions of the form if ( count( $this->types ) $singleType = $this->types[0] (which doesn't work, as first index is 1). Thus cause array to be re-indexed if a $wgLogRestriction causes a log type to be removed. Steps to reproduce the issue is make deletion log restricted, then view a (non-existent) user page. Personally I think its kind of weird/wrong that if someone restricts both the move and delete log, then viewing a non-existent will give "This page has been deleted, here's delete log:" followed by an entry from *any* public log. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
