"Brion VIBBER" posted a comment on MediaWiki.r106770.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106770#c28101

Commit summary for MediaWiki.r106770:

FU r106752: unbreak "other sizes" links on File: pages by working around the 
suck /media system.

Brion VIBBER's comment:

There's still a false being passed in in File::maybeDoTransform():

<pre>
                if ( $this->repo->fileExists( $thumbPath ) && !( $flags & 
self::RENDER_FORCE ) ) {
                        $timestamp = $this->repo->getFileTimestamp( $thumbPath 
);
                        if ( $timestamp !== false && $timestamp >= 
$wgThumbnailEpoch ) {
                                return $this->handler->getTransform( $this, 
false, $thumbUrl, $params );
                        }
                } elseif ( $flags & self::RENDER_FORCE ) {
                        wfDebug( __METHOD__ . " forcing rendering per flag 
File::RENDER_FORCE\n" ); 
                }
</pre>

Does this also need updating?

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to