"Brion VIBBER" changed the status of MediaWiki.r105999 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105999#c28139

Old Status: new
> New Status: ok

Commit summary for MediaWiki.r105999:

bring back Linker::tooltip()

Was marked deprecated with r42702 although that helper makes code a bit
nicer:

 Linker::tooltip( 'message' );

 Xml::expandAttributes( array(
        'title' => Linker::titleAttrib( 'message' )
 ) );

(the later would give you 'title=""' when 'tooltip-message' message does
not exist.

Brion VIBBER's comment:

This is ok as the usages are in old horrible patterns anyway; they should be 
fixed up and *THEN* this can be marked deprecated.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to