"Raindrift" changed the status of MediaWiki.r104687 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104687#c28146

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r104687:

Use database to track uploaded chunks and concatenate at the end.
with i18n documentation dont break phpunit

follow up r93720

Raindrift's comment:

Upon further review, I've discovered a race condition: Since this is 
synchronized through the database, if a chunk is transferred in less time than 
the current replag, the upload will fail because the slave that's being read 
from is behind.  This is actually likely to happen with some regularity.

The easiest solution is to read from master.  The slightly higher performance 
solution is to read from master only on error.


_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to