"Brion VIBBER" changed the status of MediaWiki.r105809 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105809#c28151
Old Status: new > New Status: fixme Commit summary for MediaWiki.r105809: Update wfArrayToCGI and wfCgiToArray: - 'foo' => '' now outputs "&foo=" instead of the key being omitted - 'foo' => null and 'foo' => false now omit the key instead of outputting "&foo=" - Added a test to make sure that 'foo' => true outputs "&foo=1" - Fixed a php notice caused when passing a =value-less bit like "&qwerty" to wfCgiToArray by treating it like php and extracting it as 'qwerty' => '' - Updated tests Brion VIBBER's comment: * use @dataProvider on the tests so you can loop over multiple inputs/outputs * as noted above, separate out the various items being tested * maybe throw in a round-trip test _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
