"Edokter" posted a comment on MediaWiki.r106884.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106884#c28158
Commit summary for MediaWiki.r106884:
Followup r105280
For bug 33139 "Swapping colors in new diff color scheme"
* Modified diff colorscheme to yellow[orange]/blue[blue]
- These colors attempt to address the following issues with diffs:
- Colorblindness (Protanopia/Deuteranopia)
- Cultural meaning of color (e.g., "green is good, therefore this diff is
better")
* Bumped font size up overall (actually, just removed the smaller)
* Removed dotted line around difftext
Edokter's comment:
After testing this code, I can only say: please revert! What is the reason for
this commit completely bypassing the discussion?
Not only is this a completely unilateral change that goes completely agains
what has been discussed in r105280, it looks horrible to boot. The yellow and
blue levels are totally incompatible; the bright yellow completely overpowers
the dull blue. No one asked for the font size change and pre-wrap is not
applied. The yellow/blue is a good premise, but these colors are just thrown
together from the old and the new.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
