"Catrope" changed the status of MediaWiki.r106857 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106857#c28196

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r106857:

Also handle URLs like index.php?title=Page. Fallback to main page if no title 
found. Also do a basic check if URL seems valid before redirecting.
Some other changes: pass &uselang on to main page; missed some URLs to make 
protocol-relative; put HTML outside of PHP

Catrope's comment:

<pre>
+
+?><!DOCTYPE html>
</pre>
Putting the HTML outside PHP tags like that doesn't work because you have 
variables like $escProject in there. You need to either keep it in a heredoc or 
use <?php echo $escProject; ?> in a bunch of places.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to