"GWicke" changed the status of MediaWiki.r103197 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103197#c28202
Old Status: new > New Status: ok Commit summary for MediaWiki.r103197: missing TEX_FUN1nb in html_render_deep() The new TEX_FUN1nb introduced by r99741 was not added to the html_render_deep() pattern matching list. This was spotted by an ocaml compilation warning: File "html.ml", line 74, characters 31-2966: Warning 8: this pattern-matching is not exhaustive. Here is an example of a value that is not matched: TEX_FUN1nb (_, _)::_ GWicke's comment: Handling a previously missing case just makes the failure for this case explicit, so there should be no behavior change. Marking as OK. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
