"Brion VIBBER" changed the status of MediaWiki.r94881 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94881#c28231
Old Status: ok > New Status: fixme Commit summary for MediaWiki.r94881: Relative values of the "Location" header are incorrect as stated in RFC, however they do happen and modern browsers support them. This function loops backwards through all locations in order to build the proper absolute URI - Marooned at wikia-inc.com Brion VIBBER's comment: This feels wrong; inline documentation seems to indicate that $this->respHeaders in a MWHttpRequest will hold response headers from a single response, using headers in case some values exist multiple times. After following a redirect then, we should only have one 'Location' header from the latest request. Multiple Location headers are not allowed as far as I know, so looping over the single Location header shouldn't give you much information. Is something merging the returned headers from every followed request when doing redirects or something? This could end up giving some weird bogus results in general... _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
