"Tim Starling" posted a comment on MediaWiki.r106459. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106459#c28313
Commit summary for MediaWiki.r106459: Commit Lilypond replacement from https://github.com/TheCount/score See https://wikisource.org/w/index.php?title=Wikisource%3AScriptorium&action=historysubmit&diff=323108&oldid=323079 for original discussion. Tim Starling's comment: <pre> + $cmd = $wgLilyPond + . " -dsafe='#t' -dbackend=eps --png --header=texidoc " + . wfEscapeShellArg( $lilypondFile ) + . " 2>&1"; // FIXME: This last bit is probably not portable </pre> 2>&1 is portable enough, it works in the CMD.EXE versions of Windows, which is all we support with wfEscapeShellArg(), and it works in UNIX as well. However the single quoting -dsafe='#t' is not portable, double quotes are required on Windows. Use wfEscapeShellArg( "-dsafe=#t" ). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
