"Kaldari" posted a comment on Wikimedia.r1003. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1003#c28390
Commit summary for Wikimedia.r1003: Updating error handling for database queries. Kaldari's comment: <pre> + $message = '$table cannot be empty.'; + throw new Db_Exception( $message ); </pre> This seems needlessly verbose. I would expect just: throw new Db_Exception( '$table cannot be empty.' ); Otherwise, looks OK. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
