"Kaldari" changed the status of Wikimedia.r1007 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1007#c28392

Old Status: new
> New Status: fixme

Commit summary for Wikimedia.r1007:

Updated delete(), update() and insert() with debugging and documenation.

Kaldari's comment:

<pre>
+               $where = is_array( $where ) ? implode( ' AND ', $where ) : 
$where ;
</pre>
This would be shorter and easier to read:
<pre>
if ( is_array( $where ) ) $where = implode( ' AND ', $where );
</pre>

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to