"Nikerabbit" changed the status of MediaWiki.r107107 to "fixme" and commented 
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107107#c28403

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r107107:

finished up some stuff

Nikerabbit's comment:

<pre>
+                       $links[] = $value = Linker::linkKnown(
+                               SpecialPage::getTitleFor( 'EditTerm', 
$item->getId() ),
+                               wfMsg( 'edit' )
+                       );
</pre>

$value looks unused. Should not reuse messages. The message should be escaped. 
Two instances.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to