"Nikerabbit" changed the status of MediaWiki.r107081 to "fixme" and commented 
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107081#c28425

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r107081:

added gender support for x thinks this helpful.  follow up r106743

Nikerabbit's comment:

Looks like this is not as straight forward, and message docs seems wrong too:
<pre>
39-             foreach ( $helpfulUserList as $val ) {
40-                     $userList .= $val['user_name'] . ' ';
41-             }
42-
43-             $data = '';
44-
45-             if ( $userList ) {
46:                     $data = wfMessage( 'mah-someone-marked-text' )->params( 
$userList )->escaped();
47-             }
</pre>

This is a list of users, isntead of just one. It should also use 
$wgLang->listToText() function.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to