"Kaldari" posted a comment on Wikimedia.r1048. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1048#c28437
Commit summary for Wikimedia.r1048: Added network handler to make command line calls. Kaldari's comment: <pre> + $execute = ( isset( $options['execute'] ) && !empty( $options['execute']) ) ? $options['execute'] : 'exec'; </pre> In this case !empty() isn't necessary since we already know that the variable is set (thus no chance of an unset warning). Instead you should use "&& $options['execute']" per [[Manual:Coding conventions/PHP#Pitfalls]]. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
