"^demon" posted a comment on MediaWiki.r106910. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106910#c28474
Commit summary for MediaWiki.r106910: add base template class ^demon's comment: * If this constructor isn't going to do any other work, you can just move the array initialization up to the top like <tt>public $data = array();</tt> * Having set() and setByArray() is kind of redundant. Why not just call it set() and always use the array syntax _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
