[MediaWiki-CodeReview] [MediaWiki r107229]: New comment added

Sat, 24 Dec 2011 14:56:59 -0800 

"Reedy" posted a comment on MediaWiki.r107229.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107229#c28488

Commit summary for MediaWiki.r107229:

(JavaScript) implement validation and rendering of language codes via AJAX 
method; also implement nice JS remove links for translation groups

Reedy's comment:

Minor addition/note

Some of your code in SpecialTranslatesvg is getting a bit long

<pre>
                                if( $language !== 'qqq' ){
                                        $grouphtml .= Html::element( 'br' ) .
                                                        "&#160;&#160;&#160;" . 
Xml::inputLabel( wfMsg( 'translatesvg-xcoordinate-pre' ), 
$language.'-'.$i.'-x', $language.'-'.$i.'-x', 5, $existing['x'] ) . 
                                                        "&#160;&#160;&#160;" . 
Xml::inputLabel( wfMsg( 'translatesvg-ycoordinate-pre' ), 
$language.'-'.$i.'-y', $language.'-'.$i.'-y', 5, $existing['y'] );
                                }
</pre>

Might want to break up onto a few more lines



_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to