"Krinkle" posted a comment on MediaWiki.r107164. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107164#c28495
Commit summary for MediaWiki.r107164: [Core JS] scan all /phase3/, change certain constructors to literals * new String, new Boolean, new Number -- should not be used since they don't compare very well: ; 5 !== new Number( 5 ) // true ; !!new Boolean( false ) // true, objects are truethy -- If type conversion is intended, they should be used as functions instead of constructors. * new Array, new Object -- literals are shorter, no point in not using them. Krinkle's comment: Yes and no. I was expecting more files to contain these, but fortunately this was the only one. I wrote the commit message before I did the find/replace. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
