"Nikerabbit" changed the status of MediaWiki.r107233 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107233#c28507
Old Status: new
> New Status: ok
Commit summary for MediaWiki.r107233:
Fix compat with latest SVN; add image preview; improve the range of SVGs that
can be handled.
Nikerabbit's comment:
You should consider using early returns to reduce the indenting:
<pre>if ( some prerequisite ) {
display error();
return;
}</pre>
Sometimes you need to split the methods into smaller ones to utilize that
pattern.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
