"Nikerabbit" posted a comment on MediaWiki.r107242.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107242#c28508
Commit summary for MediaWiki.r107242:
Sort languages before displaying; make languages collapsible; if nothing to
translate don't try; and fallback if textbox left blank (presumably this is the
least astonishing outcome).
Nikerabbit's comment:
<pre>
-$this->getOutput()->addHTML( Html::element( 'p', null, wfMessage(
'translatesvg-unsuccessful' )->parse() ) );
+$this->getOutput->addWikiMsg( 'translatesvg-unsuccessful' ); // Better
</pre>
The indendation is off here:
<pre>
+ Html::openElement( 'div', array(
'class' => 'mw-collapsible mw-collapsed',
+
'data-collapsetext' => wfMsg(
'translatesvg-toggle-hide' ),
+
'data-expandtext' => wfMsg( 'translatesvg-toggle-view'
) ) );
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
